Re: [PATCH] crypto: hisilicon/zip: Use the bitmap API to allocate bitmaps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 15/07/2022 à 10:33, Herbert Xu a écrit :
On Sat, Jul 09, 2022 at 06:16:46PM +0200, Christophe JAILLET wrote:
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
  drivers/crypto/hisilicon/zip/zip_crypto.c | 9 ++++-----
  1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/hisilicon/zip/zip_crypto.c b/drivers/crypto/hisilicon/zip/zip_crypto.c
index 67869513e48c..7bf53877e508 100644
--- a/drivers/crypto/hisilicon/zip/zip_crypto.c
+++ b/drivers/crypto/hisilicon/zip/zip_crypto.c
@@ -606,8 +606,7 @@ static int hisi_zip_create_req_q(struct hisi_zip_ctx *ctx)
  		req_q = &ctx->qp_ctx[i].req_q;
  		req_q->size = QM_Q_DEPTH;
- req_q->req_bitmap = kcalloc(BITS_TO_LONGS(req_q->size),
-					    sizeof(long), GFP_KERNEL);
+		req_q->req_bitmap = bitmap_zalloc(req_q->size, GFP_KERNEL);
  		if (!req_q->req_bitmap) {
  			ret = -ENOMEM;
  			if (i == 0)

You should add an include for linux/bitmap.h instead of relying
on implicit inclusion through some random header file.

Hi, most of the patches are accepted as-is, so I will not resend all of them.
I'll only add the #include if a v2 is needed or for new patches.

Thanks for the review and comment.

CJ


The same goes for all your other patches too.

Thanks,




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux