On 05.07.2022 23:51, Uwe Kleine-König wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The remove callback is only called after probe completed successfully. > In this case platform_set_drvdata() was called with a non-NULL argument > and so sha_dd is never NULL. > > This is a preparation for making platform remove callbacks return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > --- > drivers/crypto/atmel-sha.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c > index d1628112dacc..e054e0ac6fc2 100644 > --- a/drivers/crypto/atmel-sha.c > +++ b/drivers/crypto/atmel-sha.c > @@ -2669,8 +2669,7 @@ static int atmel_sha_remove(struct platform_device *pdev) > struct atmel_sha_dev *sha_dd; > > sha_dd = platform_get_drvdata(pdev); > - if (!sha_dd) > - return -ENODEV; > + > spin_lock(&atmel_sha.lock); > list_del(&sha_dd->list); > spin_unlock(&atmel_sha.lock); > -- > 2.36.1 >
