Re: [PATCH crypto 5.19] crypto: s390 - do not depend on CRYPTO_HW for SIMD implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 05, 2022 at 10:39:35AM +0800, Herbert Xu wrote:
> On Tue, Jul 05, 2022 at 03:46:53AM +0200, Jason A. Donenfeld wrote:
> > Various accelerated software implementation Kconfig values for S390 were
> > mistakenly placed into drivers/crypto/Kconfig, even though they're
> > mainly just SIMD code and live in arch/s390/crypto/ like usual. This
> > gives them the very unusual dependency on CRYPTO_HW, which leads to
> > problems elsewhere.
> > 
> > This patch fixes the issue by moving the Kconfig values for non-hardware
> > drivers into the usual place in crypto/Kconfig.
> > 
> > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> > ---
> >  crypto/Kconfig         | 114 ++++++++++++++++++++++++++++++++++++++++
> >  drivers/crypto/Kconfig | 115 -----------------------------------------
> >  2 files changed, 114 insertions(+), 115 deletions(-)
> 
> This is caused by the s390 patch for wireguard, right?

Right, but is a fix to some linker/kconfig errors related to selecting
chacha20poly1305 directly, and I'm happy to take that patch anyway, so
I'm quasi-content with the situation.

> you take this into your tree along with the wireguard patch
> where it would make more sense.
> 
> Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Alright, I'll do that.

Jason



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux