Re: [PATCH] lib/crypto: blake2s: reduce stack frame usage in self test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 20, 2022 at 09:52:43AM +0200, Jason A. Donenfeld wrote:
> Using 3 blocks here doesn't give us much more than using 2, and it
> causes a stack frame size warning on certain compiler/config/arch
> combinations:
> 
>    lib/crypto/blake2s-selftest.c: In function 'blake2s_selftest':
> >> lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>      632 | }
>          | ^
> 
> So this patch just reduces the block from 3 to 2, which makes the
> warning go away.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/linux-crypto/202206200851.gE3MHCgd-lkp@xxxxxxxxx
> Fixes: 2d16803c562e ("crypto: blake2s - remove shash module")
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> ---
>  lib/crypto/blake2s-selftest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux