> -----Original Message----- > From: Dhananjay Phadke <dphadke@xxxxxxxxxxxxxxxxxxx> > Sent: Wednesday, June 29, 2022 7:50 PM > To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>; Corentin Labbe > <clabbe.montjoie@xxxxxxxxx>; Christophe JAILLET > <christophe.jaillet@xxxxxxxxxx>; Randy Dunlap <rdunlap@xxxxxxxxxxxxx>; > Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; David S . Miller > <davem@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; > Andrew Jeffery <andrew@xxxxxxxx>; Dhananjay Phadke > <dhphadke@xxxxxxxxxxxxx>; Johnny Huang > <johnny_huang@xxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx; BMC-SW > <BMC-SW@xxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > linux-crypto@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE > reset definition > > On 6/29/2022 2:44 AM, Neal Liu wrote: > > Add HACE reset bit definition for AST2500/AST2600. > > > > Signed-off-by: Neal Liu <neal_liu@xxxxxxxxxxxxxx> > > Signed-off-by: Johnny Huang <johnny_huang@xxxxxxxxxxxxxx> > > --- > > include/dt-bindings/clock/aspeed-clock.h | 1 + > > include/dt-bindings/clock/ast2600-clock.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/include/dt-bindings/clock/aspeed-clock.h > > b/include/dt-bindings/clock/aspeed-clock.h > > index 9ff4f6e4558c..06d568382c77 100644 > > --- a/include/dt-bindings/clock/aspeed-clock.h > > +++ b/include/dt-bindings/clock/aspeed-clock.h > > @@ -52,5 +52,6 @@ > > #define ASPEED_RESET_I2C 7 > > #define ASPEED_RESET_AHB 8 > > #define ASPEED_RESET_CRT1 9 > > +#define ASPEED_RESET_HACE 10 > > NAK. > > I replied to older v5 of this patch, but this v6 also looks incorrect as per HW > manual. > > https://lore.kernel.org/linux-arm-kernel/20220629032008.1579899-1-neal_liu > @aspeedtech.com/T/#m000bd3388b3e41117aa0eef10bf6f8a6a3a85cce > > For both AST2400 and AST2500: > SCU04[10] = PECI. > > It will be best to refactor/split aspeed-clock.h into separate files. Hi, based on @Krzysztof mentioned, change these define is not allowed due to breaking ABI. So another way is to define a new value(interface), and we can change driver's implementation. I know this is not intuitive to hardware register's value, it also confused me at the first time.
