Hi David,
On Tue, Jun 14, 2022 at 12:29 AM David Howells <dhowells@xxxxxxxxxx> wrote:
> Add some selftests for signature checking when FIPS mode is enabled. These
> need to be done before we start actually using the signature checking for
> things and must panic the kernel upon failure.
>
> Note that the tests must not check the blacklist lest this provide a way to
> prevent a kernel from booting by installing a hash of a test key in the
> appropriate UEFI table.
>
> Reported-by: Simo Sorce <simo@xxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
Thanks for your patch, which is now commit 3cde3174eb910513 ("certs:
Add FIPS selftests") in v5.19-rc4.
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -75,4 +75,14 @@ config SIGNED_PE_FILE_VERIFICATION
> This option provides support for verifying the signature(s) on a
> signed PE binary.
>
> +config FIPS_SIGNATURE_SELFTEST
> + bool "Run FIPS selftests on the X.509+PKCS7 signature verification"
Is there any reason this cannot be tristate, so I can always enable
this as a module, and run the test by loading the module whenever
I want?
> + help
> + This option causes some selftests to be run on the signature
> + verification code, using some built in data. This is required
> + for FIPS.
> + depends on KEYS
> + depends on ASYMMETRIC_KEY_TYPE
> + depends on PKCS7_MESSAGE_PARSER
> +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
