On Thu, Jun 02, 2022 at 03:21:57PM +0200, Vlad Dronov wrote: > Hi, Giovanni, all, > > I've read through the patchset and it looks good to me. I would have made > the following two minor (really minor) changes. > > Add a missing "in" to the patch message: > > @@ [PATCH 1/4] crypto: qat - expose device state through sysfs for 4xxx > -allow the change of states even if the device is the down state. > +allow the change of states even if the device is in the down state. > > Probably add an indication that cfg_services has been really changed to > the sysfs-driver-qat doc for clarity: > > @@ [PATCH 4/4] crypto: qat - expose device config through sysfs for 4xxx > diff --git a/Documentation/ABI/testing/sysfs-driver-qat > b/Documentation/ABI/testing/sysfs-driver-qat > + # echo dc > /sys/bus/pci/devices/<BDF>/qat/cfg_services > + # echo up > /sys/bus/pci/devices/<BDF>/qat/state > ++ # cat /sys/bus/pci/devices/<BDF>/qat/cfg_services > ++ dc > > Anyway, please feel free to use: > > Reviewed-by: Vladis Dronov <vdronov@xxxxxxxxxx> Thanks Vladis! I'm going to rework and re-send. Also I'm going to update the KernelVersion attribute in the documentation as this patch didn't make kernel 5.19. -- Giovanni
