Hey Eric, On Thu, May 26, 2022 at 11:01:34AM -0700, Eric Biggers wrote: > On Thu, May 26, 2022 at 11:20:26AM +0200, Jason A. Donenfeld wrote: > > BLAKE2s has no use as an shash and no use is likely to ever come up. > > I'm not sure about that. Anyone who is already using shash (for supporting I'll tweak the language of the commit message. > More importantly, this is removing quite a bit of test coverage because the > extra self-tests in crypto/testmgr.c are more comprehensive than what > lib/crypto/blake2s-selftest.c does. For example they test the case where the > input data is misaligned, as well as the case where the code is executed in a > context where SIMD instructions are unavailable. > > In order for this to be acceptable, I think you'd need to update > blake2s-selftest.c to be more comprehensive. There actually already is some alignment tests. But I'll add some more and also compare implementations. v2 incoming. Jason
