Hello Pankaj,
On 11.05.22 11:16, Pankaj Gupta wrote:
>> -----Original Message-----
>> From: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
>>>> + if (ctrlpriv->era < 10) {
>>>> rng_vid = (rd_reg32(&ctrl->perfmon.cha_id_ls) &
>>>> CHA_ID_LS_RNG_MASK) >>
>>>> CHA_ID_LS_RNG_SHIFT;
>>>
>>> Check for AES CHAs for Era < 10, should be added.
>>
>> Do I need this? I only do this check for Era >= 10, because apparently there are
>> Layerscape non-E processors that indicate BLOB support via CTPR_LS_BLOB, but
>> fail at runtime. Are there any Era < 10 SoCs that are similarly broken?
>>
>
> For non-E variants, it might happen that Blob protocol is enabled, but number of AES CHA are zero.
Do you know any SoC where this is the case?
(i.e. era < 10 && CTPR_LS_BLOB && AES_CHA == 0)
> If the output of below expression is > 0, then only blob_present should be marked present or true.
> For era > 10, you handled. But for era < 10, please add the below code.
>
> (rd_reg32(&priv->ctrl->perfmon.cha_num_ls) &
> CHA_ID_LS_AES_MASK) >> CHA_ID_LS_AES_SHIFT;
Sorry, I am not fond of adding quirk handling for Hardware that might
not even exist.
Cheers,
Ahmad
>
>> Cheers,
>> Ahmad
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
