On Mon, May 09, 2022 at 04:11:27PM +0200, Greg KH wrote: > On Mon, May 09, 2022 at 02:34:17PM +0100, Giovanni Cabiddu wrote: > > Re-enable the registration of algorithms after fixes to (1) use > > pre-allocated buffers in the datapath and (2) support the > > CRYPTO_TFM_REQ_MAY_BACKLOG flag. > > > > This reverts commit 8893d27ffcaf6ec6267038a177cb87bcde4dd3de. > > Then why not just have this be a "normal" revert commit? It can be a revert commit. I didn't send a revert commit since I never saw one in the crypto mailing list. > And why is this ok for stable kernels? This feels like a new feature > (i.e. the code finally works.) Why not just have users who want to use > this use a newer kernel? What bugfix does this resolve in older kernels > (and "the driver did not work" is not really a good reason.) After the bug report in [1], the final decision was to disable the algorithms until the issue was fixed. This set is fixing the issues that cause [1] and a few other minor ones before re-enabling the algos. I think there is value in having these fixes in stable as they allow to re-enable services that were available before the 5.17 time frame. Regards, -- Giovanni [1] https://lore.kernel.org/linux-crypto/CACsaVZ+mt3CfdXV0_yJh7d50tRcGcRZ12j3n6-hoX2cz3+njsg@xxxxxxxxxxxxxx/
