On Mon, Apr 11, 2022 at 06:43:21PM +0800, zhenwei pi wrote: > From: Lei He <helei.sig11@xxxxxxxxxxxxx> > > Introduce akcipher types, also include RSA related types. > > Signed-off-by: Lei He <helei.sig11@xxxxxxxxxxxxx> > Signed-off-by: zhenwei pi <pizhenwei@xxxxxxxxxxxxx> > --- > qapi/crypto.json | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) snip > +## > +# @QCryptoAkCipherOptions: > +# > +# The options that are available for all asymmetric key algorithms > +# when creating a new QCryptoAkCipher. > +# > +# Since: 7.1 > +## > +{ 'union': 'QCryptoAkCipherOptions', > + 'base': { 'algorithm': 'QCryptoAkCipherAlgorithm' }, > + 'discriminator': 'algorithm', > + 'data': { 'rsa': 'QCryptoAkCipherOptionsRSA' }} I mistakenly suggested 'algorithm' here, but for consistency with other fields, I should have said just 'alg'. With that change Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|