On Sun, 24 Apr 2022 at 23:41, Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
>
> Variable rng_size is being initialized with a value that is never read,
> the variable is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up cppcheck warning:
> Variable 'rng_size' is assigned a value that is never used.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/char/hw_random/optee-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Sumit Garg <sumit.garg@xxxxxxxxxx>
-Sumit
> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index a948c0727b2b..96b5d546d136 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -115,7 +115,7 @@ static size_t get_optee_rng_data(struct optee_rng_private *pvt_data,
> static int optee_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
> {
> struct optee_rng_private *pvt_data = to_optee_rng_private(rng);
> - size_t read = 0, rng_size = 0;
> + size_t read = 0, rng_size;
> int timeout = 1;
> u8 *data = buf;
>
> --
> 2.35.1
>
