On Tue, Apr 19, 2022 at 4:18 AM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > In the event that random_get_entropy() can't access a cycle counter or > similar, falling back to returning 0 is really not the best we can do. > Instead, at least calling random_get_entropy_fallback() would be > preferable, because that always needs to return _something_, even > falling back to jiffies eventually. It's not as though > random_get_entropy_fallback() is super high precision or guaranteed to > be entropic, but basically anything that's not zero all the time is > better than returning zero all the time. > > This is accomplished by just including the asm-generic code like on > other architectures, which means we can get rid of the empty stub > function here. > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Max Filippov <jcmvbkbc@xxxxxxxxx> > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > --- > arch/xtensa/include/asm/timex.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx> -- Thanks. -- Max
