On Fri, Apr 08 2022 at 19:53, Jason A. Donenfeld wrote: > Some implementations were returning type `unsigned long`, while others > that fell back to get_cycles() were implicitly returning a `cycles_t` or > an untyped constant int literal. That makes for weird and confusing > code, and basically all code in the kernel already handled it like it > was an `unsigned long`. I recently tried to handle it as the largest > type it could be, a `cycles_t`, but doing so doesn't really help with > much. Instead let's just make random_get_entropy() return an unsigned > long all the time. This also matches the commonly used > `arch_get_random_long()` function, so now RDRAND and RDTSC return the > same sized integer, which means one can fallback to the other more > gracefully. Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
