On Wed, Mar 09, 2022 at 03:20:01PM +1200, Herbert Xu wrote: > This patch turns the new SHA driver into a tristate and also allows > compile testing. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> This results in: Building s390:allmodconfig ... failed -------------- Error log: In file included from drivers/crypto/xilinx/zynqmp-sha.c:6: include/linux/cacheflush.h:12:46: error: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] 12 | static inline void flush_dcache_folio(struct folio *folio) Guenter > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > index 5d7508230b7d..97455a5f05c1 100644 > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -809,8 +809,8 @@ config CRYPTO_DEV_ZYNQMP_AES > for AES algorithms. > > config CRYPTO_DEV_ZYNQMP_SHA3 > - bool "Support for Xilinx ZynqMP SHA3 hardware accelerator" > - depends on ZYNQMP_FIRMWARE > + tristate "Support for Xilinx ZynqMP SHA3 hardware accelerator" > + depends on ZYNQMP_FIRMWARE || COMPILE_TEST > select CRYPTO_SHA3 > help > Xilinx ZynqMP has SHA3 engine used for secure hash calculation.