On Mon, Mar 21, 2022 at 02:23:54PM -0400, Paul Moore wrote: > On Mon, Mar 21, 2022 at 1:45 PM Mickaël Salaün <mic@xxxxxxxxxxx> wrote: > > > > From: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx> > > > > The blacklist_init() function calls panic() for memory allocation > > errors. This change documents the reason why we don't return -ENODEV. > > > > Suggested-by: Paul Moore <paul@xxxxxxxxxxxxxx> [1] > > Requested-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> [1] > > Link: https://lore.kernel.org/r/YjeW2r6Wv55Du0bJ@xxxxxx [1] > > Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx> > > Link: https://lore.kernel.org/r/20220321174548.510516-2-mic@xxxxxxxxxxx > > --- > > certs/blacklist.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > I would suggest changing the second sentence as shown below, but > otherwise it looks good to me. > > Reviewed-by: Paul Moore <paul@xxxxxxxxxxxxxx> Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> Mickaël, I think since your patch set was not huge in the first place, I'm considering making it part of rc2 pull request while I normally try to avoid any features after rc1. It's anyway throughly tested, and generally has been around for a *long time*. I've even tested it myself a few times. Just trying to be responsible as a maintainer and if something does not feel right, I don't try to pretend that "I get it", if you know what I mean. This fully clarifies "not getting it" part :-) Thanks! BR, Jarkko
