On Thu, Mar 17, 2022 at 10:16:16AM +0100, Philipp Zabel wrote: > > What commit adad556efcdd caused was allowing the error path in > late_initcall(aes_init) to be hit before > late_initcall(crypto_algapi_init) would start the tests. OK I know what's going on now. Yes the registration had always failed but it was silent so nobody noticed. What adad556efcdd did different was to create larvals pointing to the algorithms which will hang around until all tests complete and that is what triggers the crash during unregister (that bug during unregister has always existed too, it's just that it was pretty much impossible to trigger as usually there aren't any third parties allocating tfms during the init call). I'll continue to work on the unregister crash. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt