On Sat, Mar 12, 2022 at 5:23 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > That isn't mentioned in Documentation/security/siphash.rst at all. It actually > makes it pretty clear that hsiphash() is "HalfSipHash". Send a documentation patch and I'll queue it up. > > > > So on 64-bit platforms it now throws away half of the pool. > > > > > > It should use 'u8 pool[sizeof(fast_pool->pool)]' to avoid hardcoding a size. > > > > Actually the commit message notes that we intentionally dump half of > > it on 64bit. This is intentional. > > > > It doesn't explain *why* it does that. Also, the code is much more important > than the commit message, and there's no explanation in the code at all; it just > looks like a bug. Yea. I'll augment that and send a v+1. Jason
