On Wed, Feb 23, 2022 at 08:07:01AM +0100, Ard Biesheuvel wrote: > Dereferencing a misaligned pointer is undefined behavior in C, and may > result in codegen on architectures such as ARM that trigger alignments > traps and expensive fixups in software. > > Instead, use the get_aligned()/put_aligned() accessors, which are cheap > or even completely free when CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y. > > In the converse case, the prior alignment checks ensure that the casts > are safe, and so no unaligned accessors are necessary. > > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > --- > v2: fix issue in crypto_xor_cpy() > > crypto/algapi.c | 24 +++++++++++++++++--- > include/crypto/algapi.h | 10 ++++++-- > 2 files changed, 29 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
