Hello The rockchip crypto driver is broken and do not pass self-tests. This serie's goal is to permit to become usable and pass self-tests. This whole serie is tested on a rk3328-rock64 with selftests (with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y) Regards Corentin Labbe (16): crypto: rockchip: use dev_err for error message about interrupt crypto: rockchip: do not use uninit variable crypto: rockchip: do not do custom power management crypto: rockchip: fix privete/private typo crypto: rockchip: do not store mode globally crypto: rockchip: add fallback for cipher crypto: rockchip: add fallback for ahash crypto: rockchip: better handle cipher key crypto: rockchip: remove non-aligned handling crypto: rockchip: rework by using crypto_engine crypto: rockhip: do not handle dma clock ARM: dts: rk3288: crypto do not need dma clock crypto: rockchip: rewrite type crypto: rockchip: add debugfs arm64: dts: rockchip: add rk3328 crypto node crypto: rockchip: add myself as maintainer MAINTAINERS | 6 + arch/arm/boot/dts/rk3288.dtsi | 4 +- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 12 + drivers/crypto/Kconfig | 10 + drivers/crypto/rockchip/rk3288_crypto.c | 283 +++-------- drivers/crypto/rockchip/rk3288_crypto.h | 68 ++- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 214 +++++---- .../crypto/rockchip/rk3288_crypto_skcipher.c | 449 +++++++++++------- 8 files changed, 533 insertions(+), 513 deletions(-) -- 2.34.1