Hey Sebastian, On 2/28/22, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote: > On 2022-02-24 16:29:37 [+0100], Jason A. Donenfeld wrote: >> Taking spinlocks from IRQ context is problematic for PREEMPT_RT. That >> is, in part, why we take trylocks instead. But apparently this still >> trips up various lock dependency analyzers. That seems like a bug in the >> analyzers that should be fixed, rather than having to change things >> here. > > Could you please post a lockdep report so I can take a look? I thought the problem with lockdep was stated by you somewhere in this thread? https://lore.kernel.org/lkml/YfOqsOiNfURyvFRX@xxxxxxxxxxxxx/ "But even then we need to find a way to move the crng init part (crng_fast_load()) out of the hard-IRQ." And Jonathan posted two related (?) splats he ran into. I may have gotten that all wrong, in which case, I'll just excise that part from the commit message. I'm pretty sure you want this patch either way, right? Jason