On Sun, Feb 13, 2022 at 04:25:22PM +0100, Jason A. Donenfeld wrote: > add_hwgenerator_randomness() is a function implemented and documented > inside of random.c. It is the way that hardware RNGs push data into it. > Therefore, it should be declared in random.h. Otherwise sparse complains > with: > > random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static? > > The alternative would be to include hw_random.h into random.c, but that > wouldn't really be good for anything except slowing down compile time. > > Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> > Cc: Matt Mackall <mpm@xxxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: Kalle Valo <kvalo@xxxxxxxxxx> > Cc: ath9k-devel@xxxxxxxxxxxxxxxx > Cc: Theodore Ts'o <tytso@xxxxxxx> > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > --- > drivers/char/hw_random/core.c | 1 + > drivers/net/wireless/ath/ath9k/rng.c | 1 + > include/linux/hw_random.h | 2 -- > include/linux/random.h | 2 ++ > 4 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> - Eric
