Hi Herbert Please see inline. > -----Original Message----- > From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Sent: Friday, February 11, 2022 2:49 PM > To: Harman Kalra <hkalra@xxxxxxxxxxx> > Cc: Arnaud Ebalard <arno@xxxxxxxxxxxx>; Boris Brezillon > <bbrezillon@xxxxxxxxxx>; Srujana Challa <schalla@xxxxxxxxxxx>; linux- > crypto@xxxxxxxxxxxxxxx; Jerin Jacob Kollanukkaran <jerinj@xxxxxxxxxxx>; > Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH] crypto: octeontx2 - add synchronization between > mailbox accesses > > External Email > > ---------------------------------------------------------------------- > On Fri, Feb 04, 2022 at 06:16:01PM +0530, Harman Kalra wrote: > > > > offset = msg->next_msgoff; > > + /* Write barrier required for VF responses which are handled > by > > + * PF driver and not forwarded to AF. > > + */ > > + smp_wmb(); > > Who is the reader in this case? Is it also part of the kernel? This shared region is accessed by VF driver which is a DPDK driver. > Because if a device is involved then smp_wmb is not appropriate. This is the same driver which is handling multiple platforms. In older platforms this region was normal DRAM region and was mapped in DPDK driver but in recent platforms it is device memory. Thanks Harman > > Thanks, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: > https://urldefense.proofpoint.com/v2/url?u=http- > 3A__gondor.apana.org.au_- > 7Eherbert_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj7V- > 7JdkxT_Z_SU6RrS37ys4UXudBQ_rrS5LRo&m=ho3Yrv-lqiH2g1- > aPC__mENJQ5Sl-8ZiYhq1B9w7q4JIznCaE51- > HsGGwyoybXo1&s=l3Jk2Ay8mVeXEZN8mEYcUduOUgAnBZkLP2bpGEKtwL4& > e= > PGP Key: https://urldefense.proofpoint.com/v2/url?u=http- > 3A__gondor.apana.org.au_- > 7Eherbert_pubkey.txt&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj > 7V-7JdkxT_Z_SU6RrS37ys4UXudBQ_rrS5LRo&m=ho3Yrv-lqiH2g1- > aPC__mENJQ5Sl-8ZiYhq1B9w7q4JIznCaE51-HsGGwyoybXo1&s=- > jOywGz3R15pI-vdtiom908wdVHFZVmBn7ktoqtVkYE&e=
