On Thu, Feb 17, 2022 at 09:36:41PM +0200, Gilad Ben-Yossef wrote: > Hi Again, > > Thank you for taking the time to look into this! > > However, this is an old topic that has been discussed before and the > answer really is that the selftests are wrong. They are looking at the > wrong thing. Yes, I know... > > See the discussion here: > https://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg40576.html > > I also also point out this is actually documented in the code: > > + /* See > https://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg40576.html > + * for the reason why this differs from the generic > + * implementation. > + */ Indeed. We should instead change the generic algorithm as well as the other drivers that implement XTS. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
