On Thu, Feb 10, 2022 at 10:38:28PM +0800, Sandy Harris wrote: > Add a pseudorandom generator based on the xtea cipher > > This will be used only within the kernel, mainly within the driver > to rekey chacha or dump extra random data into the input pool. > > It needs a 64-bit output to match arch_get_random_long(), and > the obvious way to get that is a 64-bit block cipher. > > xtea was chosen partly for speed but mainly because, unlike > most other block ciphers, it does not use a lot of storage > for round keys or S-boxes. This driver already has 4k bits > in the input pool and 512 bits each for chacha and hash > contexts; that is reasonable, but if anything we should > be looking at ways to reduce storage use rather than > increasing it. > > --- > drivers/char/random.c | 294 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 294 insertions(+) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
