On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > blake2s_compress_generic is weakly aliased by blake2s_generic. The Don't you mean "weakly aliased by blake2s_compress"? > Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in") > Reported-by: Miles Chen <miles.chen@xxxxxxxxxxxx> > Tested-by: Miles Chen <miles.chen@xxxxxxxxxxxx> > Tested-by: Nathan Chancellor <nathan@xxxxxxxxxx> > Link: https://github.com/ClangBuiltLinux/linux/issues/1567 > Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > Cc: Sami Tolvanen <samitolvanen@xxxxxxxxxx> > Cc: Ard Biesheuvel <ardb@xxxxxxxxxx> > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > --- Otherwise this looks fine, though it's unfortunate this is needed. You can add: Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> > Changes v1->v2: > - Wrapped columns at 80 for Eric. It is the recommended coding style, so not just for me :-) - Eric