hi, >Thanks for the patch. Could you let me know which architecture and >compiler this was broken on? If I had to guess, I'd wager arm32, and >you hit this by enabling optimized blake2s? Actually, I am merging android-common tree and test our device. I use arm64 and clang-r437112b. I'm not sure which option is the right one, grep 'BLAKE' .config shows: CONFIG_CRYPTO_BLAKE2B=y # CONFIG_CRYPTO_BLAKE2S is not set # CONFIG_CRYPTO_LIB_BLAKE2S_GENERIC=y and... I found that my patch breaks arm32 build, sorry for that. >If so, I'm not sure the problem is with weak symbols. Why should CFI >break weak symbols? Rather, perhaps the issue is that the function is >defined in blake2s-core.S? Are there some CFI macros we need for that >definition?
