On Fri, Jan 14, 2022 at 05:40:30PM +1100, Herbert Xu wrote: > On Wed, Jan 12, 2022 at 11:58:00AM +1100, Herbert Xu wrote: > > On Tue, Jan 11, 2022 at 01:43:58PM -0800, Eric Biggers wrote: > > > > > > Maybe CRYPTO_MANAGER_EXTRA_TESTS should select CRYPTO_SIMD? > > > > You're right. I was focusing only on the module dependencies > > but neglected to change the Kconfig dependencies. > > > > I'll fix this in the next version. > > ---8<--- > As testmgr is part of cryptomgr which was designed to be unloadable > as a module, it shouldn't export any symbols for other crypto > modules to use as that would prevent it from being unloaded. All > its functionality is meant to be accessed through notifiers. > > The symbol crypto_simd_disabled_for_test was added to testmgr > which caused it to be pinned as a module if its users were also > loaded. This patch moves it out of testmgr and into crypto/algapi.c > so cryptomgr can again be unloaded and replaced on demand. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> - Eric
