On Tue, Jan 11, 2022 at 11:25 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > On Tue, 11 Jan 2022 at 23:12, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > > Hi Justin, > > > > These are library variables, which means they really have no sense in > > being user selectable. Internal things to the kernel depend on them, > > or they don't. They're always only dependencies. > > > > But what does any of this have to do with blake2s? These are unrelated > changes that are not even described in the commit log of the original > patch, so let's just revert them now. If changes are needed here, we > can discuss them on the linux-crypto mailing list after the merge > window. The lib crypto stuff moved outside of `if CRYPTO`, so if you add those titles back, the root menu is going to be filled with things. I'm working on some patches now moving lib/crypto/ things into lib strictly, so the dependency is one way. I can try adding back the labels there if you want. Jason