On Sun, Jan 02, 2022 at 09:42:03PM +0100, Jason A. Donenfeld wrote: > In preparation for using blake2s in the RNG, we change the way that it > is wired-in to the build system. Instead of using ifdefs to select the > right symbol, we use weak symbols. And because ARM doesn't need the > generic implementation, we make the generic one default only if an arch > library doesn't need it already, and then have arch libraries that do > need it opt-in. > > Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx> > Cc: linux-kbuild@xxxxxxxxxxxxxxx > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > --- > Herbert - As mentioned with the vPrev, I intend to take this via the > crng/random.git tree, since it forms a dependency and I'd like to send a > pull early in 5.17 cycle. At this point I think we should push this through crypto. The changes are too invasive with respect to the crypto Kconfig files. > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 285f82647d2b..b7a2e50dcbc8 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -702,7 +702,7 @@ config CRYPTO_BLAKE2S > See https://blake2.net for further information. > > config CRYPTO_BLAKE2S_X86 > - tristate "BLAKE2s digest algorithm (x86 accelerated version)" > + bool "BLAKE2s digest algorithm (x86 accelerated version)" > depends on X86 && 64BIT > select CRYPTO_LIB_BLAKE2S_GENERIC > select CRYPTO_ARCH_HAVE_LIB_BLAKE2S This will break when CRYPTO is disabled because the x86 crypto glue code depends on the crypto subsystem. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
