Re: [PATCH] lib/mpi: Add the return value check of kcalloc()

[Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>]

On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@xxxxxxxxx>
> ---

Reviewed-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>

Best regards,
Tianjia

>   lib/mpi/mpi-mod.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>   
>   	mpi_normalize(m);
>   	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return NULL;
>   
>   	if (copy) {
>   		ctx->m = mpi_copy(m);