Am Samstag, 18. Dezember 2021, 04:27:21 CET schrieb Herbert Xu:
Hi Herbert,
> On Fri, Dec 17, 2021 at 10:41:42AM +0100, Stephan Müller wrote:
> > diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c
> > index 2d115bec15ae..b02f93805e83 100644
> > --- a/crypto/jitterentropy-kcapi.c
> > +++ b/crypto/jitterentropy-kcapi.c
> > @@ -59,6 +60,11 @@ void jent_zfree(void *ptr)
> >
> > kfree_sensitive(ptr);
> >
> > }
> >
> > +int jent_fips_enabled(void)
> > +{
> > + return fips_enabled;
> > +}
>
> Why do you need this function? And why can't it be inlined?
>
> Normally fips_enabled is entirely optimised away if FIPS is
> disabled in Kconfig. This function breaks this.
You are right, fips.h can be included into jitterentropy.c and this helper
function can be eliminated.
Thanks
>
> Thanks,
Ciao
Stephan
