Hannes Reinecke <hare@xxxxxxx> writes:
>> diff --git a/include/crypto/dh.h b/include/crypto/dh.h
>> index 15d8b2dfe4a2..59be1fe3a978 100644
>> --- a/include/crypto/dh.h
>> +++ b/include/crypto/dh.h
>> @@ -22,6 +22,13 @@
>> /** enum dh_group_id - identify well-known domain parameter sets */
>> enum dh_group_id {
>> dh_group_id_unknown = 0,
>> +#ifdef CONFIG_CRYPTO_DH_GROUPS_RFC7919
>> + dh_group_id_rfc7919_ffdhe2048 = 1, /* Constant used by test vector. */
>> + dh_group_id_rfc7919_ffdhe3072,
>> + dh_group_id_rfc7919_ffdhe4096,
>> + dh_group_id_rfc7919_ffdhe6144,
>> + dh_group_id_rfc7919_ffdhe8192,
>> +#endif
>> };
>> /**
>>
> Again, enums should be in upper case.
> And I think the rfc7919 in dh_group_id_rfc7919_ffdheXXX is redundant;
> I'd rather leave it out and name is just dh_group_id_ffdheXXX.
All upper case now in v2 and those _RFCXYZ_ parts have also been
removed.
Thanks,
Nicolai
--
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg), GF: Ivo Totev
