Am Mittwoch, 17. November 2021, 22:28:46 CET schrieb Mat Martineau: Hi Mat, > On Mon, 15 Nov 2021, Stephan Müller wrote: > > Remove the specific code that adds a zero padding that was intended > > to be invoked when the DH operation result was smaller than the > > modulus. However, this cannot occur any more these days because the > > function mpi_write_to_sgl is used in the code path that calculates the > > shared secret in dh_compute_value. This MPI service function guarantees > > that leading zeros are introduced as needed to ensure the resulting data > > is exactly as long as the modulus. This implies that the specific code > > to add zero padding is dead code which can be safely removed. > > > > Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx> > > --- > > security/keys/dh.c | 25 ++++--------------------- > > 1 file changed, 4 insertions(+), 21 deletions(-) > > Hi Stephan - > > Thanks for the cleanup! Thank you for the review. > > Acked-by: Mat Martineau <mathew.j.martineau@xxxxxxxxxxxxxxx> I have added your signature to the patch. Ciao Stephan
