Hi Vladimir, On Fri, 12 Nov 2021 at 16:12, Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> wrote: > > Hi Bhupesh, > > On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > > Print a failure message (dev_err) in case the qcom qce crypto > > driver probe() fails. > > > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Reviewed-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > --- > > drivers/crypto/qce/core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > > index 98784d63d78c..7c90401a2ef1 100644 > > --- a/drivers/crypto/qce/core.c > > +++ b/drivers/crypto/qce/core.c > > @@ -280,6 +280,7 @@ static int qce_crypto_probe(struct platform_device *pdev) > > err_mem_path_disable: > > icc_set_bw(qce->mem_path, 0, 0); > > err: > > + dev_err(dev, "%s failed : %d\n", __func__, ret); > > return ret; > > } > > > > > > in my opinion expressed earlier this change is not needed, but I'll recede, > if somebody thinks that the change is useful in any way. As I mentioned in the reply to the review comments to the previous series, the need for this failure message was actually felt to address failures seen with boot-on crypto tests via 'CRYPTO_MANAGER_EXTRA_TESTS'. So, I would suggest keeping this patch in, unless there are some major concerns with the change. Regards, Bhupesh
