On Tue, Nov 2, 2021 at 9:38 AM Tom Lendacky <thomas.lendacky@xxxxxxx> wrote: > > On 11/2/21 9:23 AM, Peter Gonda wrote: > > From: David Rientjes <rientjes@xxxxxxxxxx> > > > > + > > + nread = kernel_read(fp, sev_init_ex_nv_address, NV_LENGTH, NULL); > > Not sure if you missed the previous comment, but kernel_read can return an > error, shouldn't it be checked and fail on error? I did miss that comment. Updated to make sure nread == NV_LENGTH. > > Thanks, > Tom > > > + dev_dbg(psp_master->dev, "SEV: read %ld bytes from NV file\n", nread); > > + filp_close(fp, NULL); > > + > > + return 0; > > +} > > +
