On 11/1/21 2:18 PM, Peter Gonda wrote:
On Mon, Nov 1, 2021 at 12:41 PM Tom Lendacky <thomas.lendacky@xxxxxxx> wrote:
On 11/1/21 12:21 PM, Peter Gonda wrote:
...
+
+ fp = filp_open(init_ex_path, O_RDONLY, 0);
+ if (IS_ERR(fp)) {
+ const int ret = PTR_ERR(fp);
I don't think you need the "const" here.
Sounds good, removed. I normally default to consting a variable if I
don't expect/want it to change. What guidance should I be following
here?
Heh, I don't know... I guess since its in such a short scope it just read
easier to me. But, you're correct, const is appropriate here, so I guess
feel free to leave it in if you want.
...
"SEV: write successful to NV file\n"
Updated all messages. Should have noted the "SEV: .." format.
It's not like we were very consistent originally, but it would be nice to
have the new messages start to maintain a consistency.
Thanks,
Tom
