On Fri, Oct 15, 2021 at 7:46 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote: ... > so compared to Uwe's v6, I restored that section to the original code. > My goal here was to make the patch as simple and easy to review as > possible. Thanks for elaboration. I have got it. ... > You're right, this didn't make much sense in that patch. I moved the > line join to the previous patch, which unindented this section and > made space for this to fit on one line. Here's the revised commit: > > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=34ab316d7287 Side remark: default without break or return is error prone (okay, to some extent). Perhaps adding the return statement there will make things robust and clean. -- With Best Regards, Andy Shevchenko
