Hi Herbert, I do see the reported problem while building modules. you may use the steps to reproduce. On Fri, 1 Oct 2021 at 11:58, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 28, 2021 at 11:32:09AM -0700, Nathan Chancellor wrote: > > > > This patch as commit 3cefb01905df ("crypto: api - Fix built-in testing > > dependency failures") in -next (along with the follow up fix) causes the > > following depmod error: > > > > $ make -skj"$(nproc)" ARCH=powerpc CROSS_COMPILE=powerpc-linux- INSTALL_MOD_PATH=rootfs ppc44x_defconfig all modules_install > > depmod: ERROR: Cycle detected: crypto -> crypto_algapi -> crypto > > depmod: ERROR: Found 2 modules in dependency cycles! > > make: *** [Makefile:1946: modules_install] Error 1 > > > > Initially reported on our CI: > > > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/3732847295?check_suite_focus=true > > That's weird, I can't reproduce this. Where can I find your Kconfig > file? Alternatively, can you identify exactly what is in algapi that > is being depended on by crypto? > > The crypto module should be at the very base and there should be no > depenedencies from it on algapi. The algapi module is meant to be > on top of crypto obviously. #!/bin/sh # TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets. # # TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system. # # To install tuxmake on your system globally: # sudo pip3 install -U tuxmake # # See https://docs.tuxmake.org/ for complete documentation. tuxmake --runtime podman --target-arch mips --toolchain gcc-10 --kconfig rt305x_defconfig # to reproduce this build locally: tuxmake --target-arch=mips --kconfig=rt305x_defconfig --toolchain=gcc-10 --wrapper=sccache --environment=KBUILD_BUILD_TIMESTAMP=@1633074287 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=SCCACHE_BUCKET=sccache.tuxbuild.com --runtime=podman --image=855116176053.dkr.ecr.us-east-1.amazonaws.com/tuxmake/mips_gcc-10 config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=mips CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc' 'HOSTCC=sccache gcc' rt305x_defconfig make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=mips CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc' 'HOSTCC=sccache gcc' make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=mips CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc' 'HOSTCC=sccache gcc' uImage.gz make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=mips CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc' 'HOSTCC=sccache gcc' modules_install INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=/home/tuxbuild/.cache/tuxmake/builds/current/modinstall depmod: ERROR: Cycle detected: crypto -> crypto_algapi -> crypto depmod: ERROR: Found 2 modules in dependency cycles! make[1]: *** [/builds/linux/Makefile:1961: modules_install] Error 1 make: *** [Makefile:226: __sub-make] Error 2 make: Target 'modules_install' not remade because of errors. -- Linaro LKFT https://lkft.linaro.org