On Mon, Sep 20, 2021 at 09:44:05AM +0200, Uwe Kleine-König wrote: > -ENOENT (ie. "there is no clock") is fine to ignore for an optional > clock, other values are not supposed to be ignored and should be > escalated to the caller (e.g. -EPROBE_DEFER). Ignore -ENOENT by using > devm_clk_get_optional(). > > While touching this code also add an error message for the fatal errors. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > compared to (implicit) v1 > (https://lore.kernel.org/r/20210914142428.57099-1-u.kleine-koenig@xxxxxxxxxxxxxx) > this used dev_err_probe() as suggested by Martin Blumenstingl. > > v1 got a "Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>", I didn't add > that because of the above change. > > (Hmm, my setup is broken, the b4 patch signature was done before I added this > message. I wonder if this will break the signature ...) > > Best regards > Uwe > > drivers/char/hw_random/meson-rng.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
