On Fri, Sep 10, 2021 at 01:01:17PM -0600, Tim Gardner wrote: > Coverity warns uf an unused value: > > CID 44865 (#2 of 2): Unused value (UNUSED_VALUE) > assigned_value: Assigning value -14 to ret here, but that stored value is > overwritten before it can be used. > 2006 int ret = -EFAULT; > ... > value_overwrite: Overwriting previous write to ret with value from drbg_seed(drbg, &addtl, false). > 2052 ret = drbg_seed(drbg, &addtl, false); > > Fix this by removing the variable initializer. > > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx> > --- > crypto/drbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
