> > I have no objection to move those functions in SEV drv. > > With build fix > > Acked-by: Brijesh Singh <brijesh.singh@xxxxxxx> > Thanks for the ack. Will fix all build issues in the next version. > I was trying to keep all the guest management commands functions within > KVM because no other driver needs it. Having said that, we made > exception for the decommission and activate so we can cleanup the > firmware resource in non-process context. > Yes, ACTIVATE / DECOMMISSION is one case that illustrates the need to care about their internal relationship. And there is another case, which is the serialization requirement between DF_FLUSH and DEACTIVATE. This requires KVM to maintain an extra RWSEM. So I feel that it would be good to hide these details away from KVM even if KVM is the only user. Thanks. -Mingwei
