On 8/12/21 2:25 PM, Christoph Hellwig wrote: > On Tue, Aug 10, 2021 at 02:42:30PM +0200, Hannes Reinecke wrote: >> TLS 1.3 specifies ECDH and curve25517 in addition to the FFDHE >> groups, and these are already implemented in the kernel. >> So add support for these non-standard groups for NVMe in-band >> authentication to validate the augmented challenge implementation. > > If you think these are useful please add them to the standard. > Ok, will be omitting that patch for the next submission. I've just added them for validation of the DH exchange; but now that ffdhe seems to be reasonably stable I don't have an issue with dropping them. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
