On Fri, Aug 06, 2021 at 05:44:23PM +0800, Kai Ye wrote: > Modify the print of information that might lead to user misunderstanding. > Currently only XTS mode need the fallback tfm when using 192bit key. > Others algs not need soft fallback tfm. So others algs can return > directly. > > Signed-off-by: Kai Ye <yekai13@xxxxxxxxxx> > --- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) I still don't get the point of this change. Fallbacks are typically the software implementation, and they should never fail except when you run out of memory. So what do you gain by delaying the error from allocation time to runtime? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt