On 7/17/21 5:04 PM, Hannes Reinecke wrote: > On 7/17/21 8:30 AM, Sagi Grimberg wrote: [...] >>> + >>> +enum { >>> + NVME_AUTH_DHCHAP_HASH_SHA256 = 0x01, >> >> Maybe s/HASH/HF/ (stands for hash function, which is >> a better description). > > Or HMAC, as this is what it's used for... I would better do just NVME_AUTH_DHCHAP_SHA256. "HASH" is redundant here. Better to keep it shorter. Vlad