On Fri, Jul 16, 2021 at 06:54:03PM +0200, Ard Biesheuvel wrote:
> The updated XTS code fails to check the return code of skcipher_walk_virt,
> which may lead to skcipher_walk_abort() or skcipher_walk_done() being called
> while the walk argument is in an inconsistent state.
>
> So check the return value after each such call, and bail on errors.
>
> Fixes: 2481104fe98d ("crypto: x86/aes-ni-xts - rewrite and drop indirections via glue helper")
Add Cc stable?
> Reported-by: Dave Hansen <dave.hansen@xxxxxxxxx>
> Reported-by: syzbot <syzbot+5d1bad8042a8f0e8117a@xxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> ---
> arch/x86/crypto/aesni-intel_glue.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>
- Eric
