On Mon, Jul 05, 2021 at 09:27:37PM +0300, Leon Romanovsky wrote: > > I think, in any case, it would be good to update the Documentation based on > > which way we end up doing this. > > The request to update Documentation can be seen as an example of > choosing not-good API decisions. Expectation to see all drivers to > use same callbacks with same vfio-core function calls sounds strange > to me. It is not vfio-core, it is vfio-pci-core. It is similar to how some of the fops stuff works, eg the generic_file whatever functions everyone puts in. It would be improved a bit by making the ops struct mutable and populating it at runtime like we do in RDMA. Then the PCI ops and driver ops could be merged together without the repetition. Probably something that is more interesting if there are more drivers as it is a fair amount of typing to make. Jason
