On 6/7/21 9:54 AM, Borislav Petkov wrote: > On Wed, Jun 02, 2021 at 09:04:00AM -0500, Brijesh Singh wrote: >> static bool early_setup_sev_es(void) > This function is doing SNP init now too, so it should be called > something generic like > > do_early_sev_setup() > > or so. Okay, noted. >> #define GHCB_SEV_ES_GEN_REQ 0 >> #define GHCB_SEV_ES_PROT_UNSUPPORTED 1 >> +#define GHCB_SEV_ES_SNP_UNSUPPORTED 2 > GHCB_SNP_UNSUPPORTED Noted. > >> +static bool __init sev_snp_check_hypervisor_features(void) > check_hv_features() > > is nice and short. Noted. >> diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c >> index 77a754365ba9..9b70b7332614 100644 >> --- a/arch/x86/kernel/sev.c >> +++ b/arch/x86/kernel/sev.c >> @@ -609,6 +609,10 @@ static bool __init sev_es_setup_ghcb(void) > Ditto for this one: setup_ghcb() Noted. > > Thx. >
