Re: [PATCH v7,2/4] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chun-Yi",

I love your patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on linus/master v5.13-rc2 next-20210521]
[cannot apply to crypto/master sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210522-220349
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: sparc64-randconfig-s032-20210522 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/928555596c9cd62caabf8777ed8152ddac2609ef
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210522-220349
        git checkout 928555596c9cd62caabf8777ed8152ddac2609ef
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from security/integrity/digsig.c:18:
>> include/keys/system_keyring.h:72:1: error: expected identifier or '(' before '{' token
      72 | {
         | ^
   In file included from security/integrity/digsig.c:18:
   include/keys/system_keyring.h:70:19: warning: 'is_key_on_revocation_list' declared 'static' but never defined [-Wunused-function]
      70 | static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +72 include/keys/system_keyring.h

734114f8782f6c David Howells 2017-04-03  60  
56c5812623f953 Eric Snowberg 2021-01-22  61  #ifdef CONFIG_SYSTEM_REVOCATION_LIST
56c5812623f953 Eric Snowberg 2021-01-22  62  extern int add_key_to_revocation_list(const char *data, size_t size);
928555596c9cd6 Lee, Chun-Yi  2021-05-21  63  extern int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
928555596c9cd6 Lee, Chun-Yi  2021-05-21  64  				     enum key_being_used_for usage);
56c5812623f953 Eric Snowberg 2021-01-22  65  #else
56c5812623f953 Eric Snowberg 2021-01-22  66  static inline int add_key_to_revocation_list(const char *data, size_t size)
56c5812623f953 Eric Snowberg 2021-01-22  67  {
56c5812623f953 Eric Snowberg 2021-01-22  68  	return 0;
56c5812623f953 Eric Snowberg 2021-01-22  69  }
928555596c9cd6 Lee, Chun-Yi  2021-05-21  70  static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
928555596c9cd6 Lee, Chun-Yi  2021-05-21  71  					    enum key_being_used_for usage);
56c5812623f953 Eric Snowberg 2021-01-22 @72  {
56c5812623f953 Eric Snowberg 2021-01-22  73  	return -ENOKEY;
56c5812623f953 Eric Snowberg 2021-01-22  74  }
56c5812623f953 Eric Snowberg 2021-01-22  75  #endif
56c5812623f953 Eric Snowberg 2021-01-22  76  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux