On Wed, May 12, 2021 at 03:27:19PM +0800, Zou Wei wrote: > diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c > index ce439a0..83a5d30 100644 > --- a/drivers/crypto/hisilicon/qm.c > +++ b/drivers/crypto/hisilicon/qm.c > @@ -1570,17 +1570,10 @@ static ssize_t qm_cmd_write(struct file *filp, const char __user *buffer, > if (count > QM_DBG_WRITE_LEN) > return -ENOSPC; > > - cmd_buf = kzalloc(count + 1, GFP_KERNEL); > - if (!cmd_buf) > + cmd_buf = memdup_user_nul(buffer, count); > + if (IS_ERR(cmd_buf)) > return -ENOMEM; You should return the actual error and not ENOMEM. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
